search

BlockPo / BlockPo-to-Tradelayer

Incubation Repo for the TradeLayer protocol, 0.2.0
http://www.tradelayer.org
Other
8 stars 8 forks source link

Change Address not adding to addChangeAddress raw tx RPC #423

Closed patrickdugan closed 3 years ago

patrickdugan commented 3 years ago

When it comes to building transactions with other payloads than the instant trade tx types, we've had years of functionality with the addChangeAddress RPC where the tx comes out differently after applying the RPC, and the resulting tx has a change output. However we haven't been able to replicate that with the instant_trade tx types. We need to examine this closer and either make special case logic for those payloads to ensure the change output is added, or create a new RPC, or possibly something was added to make this once-consistently-functional RPC stop being as functional.

patrickdugan commented 3 years ago

Problem was mismatch in fee vs. change output value. Closed.