Dmoney - Githubissues

BlockPo / BlockPo-to-Tradelayer

Incubation Repo for the TradeLayer protocol, 0.2.0

http://www.tradelayer.org

Other

8 stars 8 forks source link

Dmoney #478

Closed santos177 closed 2 years ago

santos177 commented 2 years ago

This Pull Request satisfy #473 and #472 and include:

All rpctx for create, send and redeem pegged currency added.
Interest funcion included

@patrickdugan feel free to review it all.

patrickdugan commented 2 years ago

No conflicts! Nice.

patrickdugan commented 2 years ago

I didn't see anything that jumped out but the interest function had a lot commented out and I wasn't sure if it was covering all bases. We'll make sure everything passes tests after we get the core derivatives tests passing (these depend on those).

Also I was looking around for some indication of a reserve-vault system keeping tracking of all these cubby holes of margin+contracts... do you store records about that in the Tallymap?