search

BlockPo / BlockPo-to-Tradelayer

Incubation Repo for the TradeLayer protocol, 0.2.0
http://www.tradelayer.org
Other
8 stars 8 forks source link

Re-Do Dex Lvl. 1 Transaction as OP_Return #83

Closed patrickdugan closed 4 years ago

patrickdugan commented 5 years ago

The original Dex model was based on multisig in the old, weird sense, not the cool, modern, Lightning Network-esque sense, and included the Exodus address as a reference output in each transaction. These BTC dusts actually added up over the years to a couple of BTC. It was made to pin that tranasction to being a part of this system, where all the Mastercoins originated from Exodus, and move by reference to it. But then Class C and D transactions using OP_Return game to proliferate in the 2016 and later version of Omni.

Now we must re-do Dex Lvl. 1 to avoid any reference to an exodus address. Make Offer, Accept Offer and Deliver_LTC will become their own tx types as OP_Return, with the existing RPCs for them being adjusted to the new model. Make Offer should be modified so that a reference address can allow the token seller to tag a multisig trade channel for use in atomically closing a trade for LTC, but if Make Offer doesn't have a reference address then it is assumed to be an open offer on the global orderbook.

santos177 commented 4 years ago

Working on this issue on dex branch

patrickdugan commented 4 years ago

Good, this is something we really ought to have!

On Thu, Oct 17, 2019 at 7:41 PM Santos notifications@github.com wrote:

Working on this issue on dex branch

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/BlockPo/BlockPo-to-Tradelayer/issues/83?email_source=notifications&email_token=AAS2CBKJB73O6JXRHHG5AQLQPDSYJA5CNFSM4IFMJZMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBRX3JI#issuecomment-543391141, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAS2CBNSIUKX5CXNMXZNSCLQPDSYJANCNFSM4IFMJZMA .