search

BlockResearchGroup / compas_tna

Form finding of funicular networks in compression with vertical loads using Thrust Network Analysis
https://blockresearchgroup.github.io/compas_tna
MIT License
13 stars 9 forks source link

_edges in horizontal_nodal_numpy needs to be expressed in _vertex indices... #27

Closed tkmmark closed 1 year ago

tkmmark commented 3 years ago

Because the latest exciting revision of TNA only draws the interior vertices of the FormDiagrams as faces in the ForceDiagram, and therefore include only the spaces surrounding these nodes as vertices in the ForceDiagram... and because ForceDiagram's keys are drawn directly from FormDiagram's keys... the mapping between vertex key and index in the ForceDiagram is more necessary than ever.

Consider inserting: _edges = [[_k_i[u], _k_i[v]] for u, v in _edges]

As is already the case in horizontal_numpy...

tkmmark commented 3 years ago

@brgcode

tomvanmele commented 3 years ago

that is indeed an oversight, probably because horizontal_nodal_numpy is a bit deprecated in favour of horizontal_nodal and received less attention recently. i will add the indexing...

tomvanmele commented 3 years ago

should be fixed. please check and close if solved...

juney-lee commented 3 years ago

@tkmmark has this been resolved?

tkmmark commented 1 year ago

Yes, resolved by Tom I believe. Thanks