BlockScience / aztec-gddt

Aztec Granular Design Digital Twin
Apache License 2.0
10 stars 0 forks source link

Timesteps hard coded for exogenous time series #215

Open SeanMcOwen opened 4 months ago

SeanMcOwen commented 4 months ago

In params.py, there is TIMESTEPS which is being set to figure out the size of the timeseries to use for gas and similar.

There is a problem that it is not dynamic to changing the sim params. However it still runs since it just uses the last value of the time series.

Two potential solutions:

danlessa commented 4 months ago

@SeanMcOwen option one will likely degrade simulation performance, and I would avoid it.

We can consider option 3: consuming the gas time series from L1 time rather than Timestep units for the index. We would be required to generate more points than timesteps (e.g. maybe by a factor of 5x or 10x). The nice thing is that we would make the gas series invariant in time.