search

BlockScience / aztec-gddt

Aztec Granular Design Digital Twin
Apache License 2.0
10 stars 0 forks source link

p_select_proposal bug #266

Open SeanMcOwen opened 3 months ago

SeanMcOwen commented 3 months ago

In the code there was a block with bug written down:

BUG: do this for all phase evolving logic.

BUG: make sure that this is compatible when the time evolution is dynamical, eg, 1 ts = many blocks

updated_process.current_phase_init_time = state["time_l1"]

SeanMcOwen commented 3 months ago

Should this be taken care of or should I remove the text?

SeanMcOwen commented 3 months ago

Remove the bug message and but create a test to make sure the timesteps are correctly working

SeanMcOwen commented 3 months ago

Might be solved by #293