search

BlockScience / aztec-gddt

Aztec Granular Design Digital Twin
Apache License 2.0
10 stars 0 forks source link

Why are all the remaining time things less than and not <= 0? #269

Closed SeanMcOwen closed 3 months ago

SeanMcOwen commented 3 months ago

i.e. look at p_commit_bond

jackhack00 commented 3 months ago

I believe we decremented before checking, meaning at time 0 we should still be in the phase.

If that is incorrect, should probably be <=0

SeanMcOwen commented 3 months ago

s_current_process_time adds in the delta blocks, and then we are comparing against max phase duration - current time in process.

This PSUB gets run at the very beginning. I think it should be fine as long as there is nothing that runs between initializing the phase and reaching that substep (otherwise there would be an extra time taken).

Going to close for now