Some exogenous processes use timesteps and some use l1 blocks, probably good to standardize

BlockScience / aztec-gddt

Aztec Granular Design Digital Twin

Apache License 2.0

10 stars 0 forks source link

Some exogenous processes use timesteps and some use l1 blocks, probably good to standardize #283

Closed SeanMcOwen closed 2 months ago

SeanMcOwen commented 2 months ago

I.e. check_for_censorship uses time_l1 versus #275

jackhack00 commented 2 months ago

agreed, but might want to discuss to make sure iirc there was some trip up as we don't have equal timesteps and l1blocks (since we sometimes fastforward)

SeanMcOwen commented 2 months ago

Switch to L1 blocks

SeanMcOwen commented 2 months ago

Spawning a tier3 issue to do a more rigorous testing to make sure everything is aligned with L1 blocks, i.e. make sure no exogenous series would now break: #313

SeanMcOwen commented 2 months ago

[x] Switch value_from_param_timeseries_suf to use l1
[x] Check all other places timestep is called
[x] steady_state_l1_gas_estimate
[x] steady_state_blob_gas_estimate

SeanMcOwen commented 2 months ago

Also spawns this tier 5: #314