BlockScience / aztec-gddt

Aztec Granular Design Digital Twin
Apache License 2.0
10 stars 0 forks source link

Why is p_evolve_time_dynamical being used with the state and not the parameters for advancing the l1 blocks #291

Closed SeanMcOwen closed 2 months ago

SeanMcOwen commented 2 months ago

def p_evolve_time_dynamical( params: AztecModelParams, _2, _3, state: AztecModelState ) -> SignalTime: """ Policy function giving the change in number of blocks.

Args:
     params (AztecModelParams): The current parameters of the model.

Returns:
    Signal:
        a dictionary of variables that can be used in an update
"""
return {"delta_blocks": state["advance_l1_blocks"]}
SeanMcOwen commented 2 months ago

This might be fine but need to check because only params are in the docstring

jackhack00 commented 2 months ago

@danlessa My opinion is that we just copy pasted some docstrings, but lets verify first

SeanMcOwen commented 2 months ago

Might be an issue with dynamical vs. fixed block duration