search

BlockScience / aztec-gddt

Aztec Granular Design Digital Twin
Apache License 2.0
10 stars 0 forks source link

Sanity Check: Block reward #294

Open SeanMcOwen opened 1 month ago

SeanMcOwen commented 1 month ago

I think it is fine, but something feels off about this for the block reward:

- total_phase_duration = p['phase_duration_proposal_max_blocks'] + p['phase_duration_reveal_max_blocks'] + p['phase_duration_commit_bond_max_blocks'] + p['phase_duration_rollup_max_blocks'])
- expected_l2_blocks_per_day = params['l1_blocks_per_day'] / total_phase_duration
- reward = params['daily_block_reward'] / expected_l2_blocks_per_day
jackhack00 commented 1 month ago

context: since we set block_reward "statically" in params, we had to find a way to represent a constant inflation (aka the daily inflation stays the same), while not paying weird rewards when we change phase duration. Setting a per_block reward alone would have paid out double for 50% duration blocks.

SeanMcOwen commented 1 month ago

@jackhack00 Gotcha, seems fine then? I guess they probably would care only about daily inflation, not block by block inflation?