search

BlockScience / aztec-gddt

Aztec Granular Design Digital Twin
Apache License 2.0
10 stars 0 forks source link

Possible Bug: Is transactions not getting reset? #301

Closed SeanMcOwen closed 2 months ago

SeanMcOwen commented 2 months ago

In s_transactions, we have the state being updated with the new transactions, but won't that have us double count in the following timesteps stuff like the number of slashes?

jackhack00 commented 2 months ago

@danlessa

SeanMcOwen commented 2 months ago

I can also check it out more deeply myself if it is not an obvious reason

SeanMcOwen commented 2 months ago

Not getting cleared, meant for history of all transactions

SeanMcOwen commented 2 months ago

Need to check if slashes get double counted, but it might be filtered

SeanMcOwen commented 2 months ago

It should be filtered out by when

SeanMcOwen commented 2 months ago

Checked a few places, seems to be fine, will close with branch merge