BlockScience / aztec-gddt

Aztec Granular Design Digital Twin
Apache License 2.0
10 stars 0 forks source link

Expected rewards and expected costs for p_submit_proof are hardcoded #302

Closed SeanMcOwen closed 2 months ago

SeanMcOwen commented 2 months ago
# expected_rewards = params['daily_block_reward']
                # expected_rewards *= params['rewards_to_provers']
                # expected_rewards /= expected_l2_blocks_per_day
                expected_rewards = 1
                assert expected_rewards >= 0, "SUBMIT PROOF: Expected rewards should be positive."

                # expected_costs: float = params["op_cost_prover"]
                # expected_costs += fee
                # expected_costs += SAFETY_BUFFER
                # expected_costs *= params['gwei_to_tokens']
                expected_costs = 0
                assert expected_costs == 0, "SUBMIT PROOF: Expected costs should be zero."
jackhack00 commented 2 months ago

all rewards and costs should be set through params, not hardcoded. We currently have one op_costs bucket, which we might slightly rework. Can discuss before implementation

SeanMcOwen commented 2 months ago

Currently modular, with an issue here #311 for implementing a basic profitability thing from parameters