Blockception / BC-Minecraft-Bedrock-Diagnoser

A typescript package library that provides diagnostics for Minecraft bedrock projects
https://www.npmjs.com/package/bc-minecraft-bedrock-diagnoser
BSD 3-Clause "New" or "Revised" License
2 stars 2 forks source link

minecraft:grass_block is not considered a valid block #227

Closed Xterionix closed 1 month ago

Xterionix commented 2 months ago

image

Likely an issue with the project repo? Unsure though

DaanV2 commented 2 months ago

Do you have an file example for me 🤔

Xterionix commented 2 months ago
{
    "format_version": "1.20.80",
    "minecraft:block": {
        "description": {
            "identifier": "pv:horsetail_block",
            "states": {
                "pv:growth": [ 0, 1, 2 ]
            }
        },
        "permutations": [
            {
                "condition": "query.block_state('pv:growth') == 0",
                "components": {
                    "minecraft:geometry": "geometry.pv_horsetail_sm",
                    "minecraft:material_instances": {
                        "*": {
                            "texture": "horsetail_small",
                            "render_method": "alpha_test"
                        }
                    },
                    "minecraft:placement_filter": {
                        "conditions": [ {
                                "allowed_faces": [
                                    "up"
                                ],
                                "block_filter": [
                                    "grass"
                                ]
                            } ]
                    },
                    "minecraft:selection_box": {
                        "origin": [ -3, 0, -3 ],
                        "size": [ 6, 8, 6 ]
                    }
                }
            },
            {
                "condition": "query.block_state('pv:growth') == 1",
                "components": {
                    "minecraft:geometry": "geometry.pv_horsetail_sm",
                    "minecraft:material_instances": {
                        "*": {
                            "texture": "horsetail_medium",
                            "render_method": "alpha_test"
                        }
                    },
                    "minecraft:selection_box": {
                        "origin": [ -3, 0, -3 ],
                        "size": [ 6, 14, 6 ]
                    }
                }
            },
            {
                "condition": "query.block_state('pv:growth') == 2",
                "components": {
                    "minecraft:geometry": "geometry.pv_horsetail_l",
                    "minecraft:material_instances": {
                        "*": {
                            "texture": "horsetail_large",
                            "render_method": "alpha_test"
                        }
                    },
                    "minecraft:selection_box": {
                        "origin": [ -0.5, 0, -0.5 ],
                        "size": [ 1, 16, 1 ]
                    }
                }
            }
        ],
        "components": {
            "minecraft:light_dampening": 0,
            "minecraft:light_emission": 0,
            "minecraft:map_color": "#4E8847",
            "minecraft:collision_box": false,
            "minecraft:placement_filter": {
                "conditions": [
                    {
                        "block_filter": [
                            "minecraft:dirt",
                            "minecraft:dirt_with_roots",
                            "minecraft:grass_block",
                            "minecraft:podzol",
                            "minecraft:sand",
                            "minecraft:moss_block"
                        ],
                        "allowed_faces": [
                            "up"
                        ]
                    }
                ]
            },
            "minecraft:custom_components": [
                "pv:plant"
            ],
            "minecraft:loot": "loot_tables/blocks/horsetail.json"
        }
    }
}
Xterionix commented 2 months ago

I logged all the vanilla blocks, bc_minecraft_bedrock_vanilla_data_1.MinecraftData.vanilla.BehaviorPack.blocks.forEach(x => console.log(x.id)) It's outdated. It's missing a lot of the newer flattened blocks too. How are you updating this list? The VP repo has a lit of all the vanilla blocks, has this just not been updated for 1.21?

DaanV2 commented 1 month ago

The last one in the vanilla data is: 1.21.0.3

DaanV2 commented 1 month ago

Aah noticed that the blocks file is still a manual file, its has been updated for now