Blockception / BC-Minecraft-Bedrock-Diagnoser

A typescript package library that provides diagnostics for Minecraft bedrock projects
https://www.npmjs.com/package/bc-minecraft-bedrock-diagnoser
BSD 3-Clause "New" or "Revised" License
2 stars 2 forks source link

Sound Filepath Schema - vanilla sound paths reused in new sound definitions give `resourcepack.sound.missing` error #276

Closed dargaCode closed 2 weeks ago

dargaCode commented 3 weeks ago

Describe the bug

I'm creating new sound_definitions which reuse some vanilla sounds (recategorized into different volume slider, prioritized and pitched differently, etc)

The definitions work functionally, and the sounds from my new block play successfully in game, but Blockception is showing an error for the paths to those vanilla files (since they don't actually exist in my RP folder)

To Reproduce Steps to reproduce the behavior:

  1. Create 'development_resource_packs/[any pack name]/sounds/sound_definitions.json'
  2. Create any sound definition which reuses a vanilla sound path, eg

    
    development_resource_packs/RP/sounds/sound_definitions.json:
    
    {
       "format_version": "1.20.20",
       "sound_definitions": {
           "test": {
               "sounds": ["sounds/random/pop", { "name": "sounds/random/pop2" }]
           }
       }
    }
  3. Save file or otherwise trigger Blockception schema validation
  4. See error resourcepack.sound.missing for both versions of the sounds path syntax:
    1. The naked string `["sounds/random/pop"]
    2. The configurable object: {"name": "sounds/random/pop2"}
  5. Restart Minecraft
  6. Verify the sound from the new definition, eg /playsound test plays correctly

Expected behavior Blockception Sound Filepath Schema can recognize the path of any vanilla sound file as valid, and does not throw error

Screenshots

Screenshot 2024-11-06 at 3 42 57 PM Screenshot 2024-11-06 at 3 43 21 PM

Desktop environment

  1. OS: Windows 10 - v22H2 (via Bootcamp)
    • Editor: VSCode - v1.95.1
    • Blockception: BlockceptionLtd.blockceptionvscodeminecraftbedrockdevelopmentextension - v8.0.10
  2. OS: MacOs Sequoia - v15.0.1
    • Editor: VSCode - v1.94.2
    • Blockception: BlockceptionLtd.blockceptionvscodeminecraftbedrockdevelopmentextension - v8.0.10

Additional context

Xterionix commented 2 weeks ago

This shouldn't be on the schema repo and the issue's already been made on the diagnoser repo. https://github.com/Blockception/BC-Minecraft-Bedrock-Diagnoser/issues/216

DaanV2 commented 2 weeks ago

Moved it to diagnoser

Xterionix commented 2 weeks ago

Duplicate of #216

DaanV2 commented 2 weeks ago

I know, just keeping it here for now as history, think I also got the problem now and started fix for both