BlockchainCommons / GordianCosigner-iOS

Offline PSBT signer for iOS or MacOS
Other
8 stars 5 forks source link

UX Issues in Export PSBT via System Share Sheet #12

Open ChristopherA opened 3 years ago

ChristopherA commented 3 years ago

When I export a PSBT as a file and then via System Share to iCloud Files, I get a very confusing dialogue (see below)

Related:

a) Other apps default to folder to make things easier, should we? Gordian, or maybe Gordian/PSBTs? b) Is there yet a standard way to add comments to PSBTs? I'd love to offer some metadata about this PSBT. c) I think it would be fabulous if we could add the PSBT LifeHash as an file icon for this file. /cc @wolfmcnally is there an easy way to do this in UIKit? d) We need a generic UR for for hash that LifeHash uses, for those situations where the we want to share a LifeHash but not the source data, for those cases where the source data is on another device /cc @wolfmcnally

PNG image

wolfmcnally commented 3 years ago

@ChristopherA d) We need a generic UR for for hash that LifeHash uses, for those situations where the we want to share a LifeHash but not the source data, for those cases where the source data is on another device.

The basic digest (we're calling it "the digest" now, not "fingerprint" to avoid confusion with, e.g., HDKey fingerprints) that LifeHash uses is the SHA256 of the data. As far as I can determine, there isn't an existing tag for anything like this, so we can define a CBOR tag and UR type that represents a SHA256 digest suitable for use with LifeHash. I'll create a BCR for this.