search

BlockchainCommons / GordianCosigner-iOS

Offline PSBT signer for iOS or MacOS
Other
8 stars 5 forks source link

UR crypto-account export default, text optional #29

Open ChristopherA opened 3 years ago

ChristopherA commented 3 years ago

Just like the Cosigner export, needs UR/text button

PNG image 8

Fonta1n3 commented 3 years ago

This is an Account Map, there is no UR type for an account map yet. Not clear on this one. You want to stop exporting account map and instead export a ur:crypto-account? This would break compatibility with Specter, Fully Noded and Gordian Wallet.

ChristopherA commented 3 years ago

Then the task is to work out with @wolfmcnally what we need to do to have a UR based AccountMap v2 rather than using JSON.

Fonta1n3 commented 3 years ago

Then the task is to work out with @wolfmcnally what we need to do to have a UR based AccountMap v2 rather than using JSON.

Adding optional fields for blockheight and label to crypto-output would cover us for a UR Account map equivalent.

Ensuring these optional fields can be used within crypto-account (which consists of an array of crypto-output) would do the trick IMHO.

ChristopherA commented 3 years ago

Don’t forget notes, the human readable “why” for this account, and that we’ll need to support the policy map version.

wolfmcnally commented 3 years ago

I'll look into adding these fields to crypto-account.

Fonta1n3 commented 3 years ago

I'll look into adding these fields to crypto-account.

It would make more sense to me to add this to crypto-output as an account map simply consists of an output descriptor. This way we do not limit ourselves to BIP44 accounts only for easy future extensibilty.

Considering crypto-account consists of an array of crypto-outputs, crypto-account would inherit the optional labels.