BlockchainCommons / GordianQRTool-iOS

UR & QR code storage for iOS and MacOS
Other
5 stars 7 forks source link

More Types #27

Closed ChristopherA closed 3 years ago

ChristopherA commented 3 years ago

We need to add more label types, and @shannona and I need docs on updating them in the code.

Related, if a label is added in a future release, old "unknown" labels need to be updated, or a button in settings to rescan labels.

Starting a list of more types of QRs here:

Fonta1n3 commented 3 years ago

+1 for giving an example! please provide examples and I will happily add them

have added microsoft auth and otp auth for next build.

ChristopherA commented 3 years ago

@ShannonA — what should the "unknown" type be? unknown? blank? text?

ChristopherA commented 3 years ago

At minimum we should support labelling the schemes that Apple directly supports with handers: https://developer.apple.com/library/archive/featuredarticles/iPhoneURLScheme_Reference/Introduction/Introduction.html

Here are some common QRs that I've found in the wild that are supported by 3rd party QR apps:

shannona commented 3 years ago

I think "unknown" is good for the unknown stuff.

shannona commented 3 years ago

A few others I stumbled upon while testing the Vault out:

bitcoin: [bitcoin address] payto: [https://datatracker.ietf.org/doc/html/rfc8905] iban: [International Bank Account Number?] text without any prefix [that's probably genuinely unknown]

Fonta1n3 commented 3 years ago

Latest commit adds all of these types 👍🏻