BlockchainCommons / GordianQRTool-iOS

UR & QR code storage for iOS and MacOS
Other
5 stars 7 forks source link

App Should Be QR Tool, Not QR Vault #61

Open shannona opened 3 years ago

shannona commented 3 years ago

Based on the PR in process (https://github.com/BlockchainCommons/GordianQRTool-iOS/pull/60), the app is being called "QR Vault" at a deep level, including entitlements, the project file, UI Tests, and perhaps most notably, the name of the cloud container. We want to update this to "QR Tool" as much as possible, especially for anything like the cloud container that could have user impact.

ChristopherA commented 3 years ago

@Fonta1n3 i have screenshots of all of my test QRs, so deleting my cloud items in next release is ok. Thus please update app iCloud container name and other internal names to Gordian QR Tool or QR Tool.

Fonta1n3 commented 3 years ago

Based on the PR in process (#60), the app is being called "QR Vault" at a deep level, including entitlements, the project file, UI Tests, and perhaps most notably, the name of the cloud container. We want to update this to "QR Tool" as much as possible, especially for anything like the cloud container that could have user impact.

hmm I did rename the project, test files etc. I do not think any of this would have any effect on any user.

I am really not comfortable making changes to core data items at this point as it will likely break everything.