search

BlockchainCommons / GordianQRTool-iOS

UR & QR code storage for iOS and MacOS
Other
5 stars 7 forks source link

Fixed #72 "App Crashes if Default Message Cell Removed". #73

Closed wolfmcnally closed 3 years ago

wolfmcnally commented 3 years ago

Also fixed bug where after deleting all QR codes, the message "Authenticate to access your data" would appear even when already authenticated. Correct message should have been "Tap the Paste or Scan button to add a QR code."

shannona commented 3 years ago

LGTM, thanks for also fixing the messaging!

shannona commented 3 years ago

We do now have the opposite logic problem here: if the user is not authed and there's nothing in their QR list, they see the "Paste or Scan" message, rather than the "Tap to Authenticate". That's not a show-stopper, so I'm not going to slow the release to fix the iPhone crashing right now, but I'll file an issue to fix it.

It's this line that's the problem:

                if let encryptedData = encryptedData, !encryptedData.isEmpty {
                    emptyCell.textLabel?.text = "Authenticate to access your data."
                } else {

I don't know how to check for authentication in any way other than this test for encryptedData.

shannona commented 3 years ago

New logic bug is #74