Closed ChristopherA closed 2 years ago
@ChristopherA @shannona Please add a list of the derivations and the annotations you would like SeedTool to display with them.
You'll need to coordinate with other members of BC community on about the edge cases. @Fonta1n3 I think tests over 40 with Fully Noded, and recovery should support all of them. Base line are current recommended, which are segwt, nested-segwit, and cosigner 48.,legacy is bitcoin-core hd, electrum legacy (which I think handles change differently), legacy P2PKH (with a variant that I think Bred wallet used)) BIP44 & 45. Then there is the future, which single key taproot is the the most important.
Long-term I hope all of these go away in favor of just exchange of descriptors.
@Fonta1n3, is there a source of truth you use for the derivations you support, or a document you've produced yourself that I can refer to?
Two different issues here:
In the Key Request pane, it should say what this derivation is for (segwit xpub, co-signer xpub, etc.) if it is a known derivation, and otherwise should give a strong warning if it is for an unknown coin, and a lesser warning if we know the coin, but it we don't know what the child derivation is used for.
I really would like this for our list current small list of standard types for the 1.4 release.
The second issue is that there is larger list of known derivations, that at some release (1.6?) we should support, and do more detail on warning.
Rescoping for 1.4 to adding the long name (or unknown) to the Key Request screen.
This should be addressed in the next beta.
@wolfmcnally as of 54, I'm not seeing a description.
Now showing those details:
When a request is made for keys with common derivations, Seed Tool should say more.
For instance with this
crypto-request
:the current first screen is:
This screen should probably say that this is likely a request to participate in a segwit multisig account, as one of multiple other keys from others. (Exact language for review by @ShannonA).