BlockchainCommons / GordianSeedTool-iOS

Cryptographic Seed Manager for iOS
Other
39 stars 9 forks source link

When responding to key requests, describe important kinds of derivations #114

Closed ChristopherA closed 2 years ago

ChristopherA commented 2 years ago

When a request is made for keys with common derivations, Seed Tool should say more.

For instance with this crypto-request:

94F400FC-E145-491D-A03B-CC5BBFC6C7DA

the current first screen is:

E63AF1F6-F222-4B7C-943C-739FCC1BD304

This screen should probably say that this is likely a request to participate in a segwit multisig account, as one of multiple other keys from others. (Exact language for review by @ShannonA).

wolfmcnally commented 2 years ago

@ChristopherA @shannona Please add a list of the derivations and the annotations you would like SeedTool to display with them.

ChristopherA commented 2 years ago

You'll need to coordinate with other members of BC community on about the edge cases. @Fonta1n3 I think tests over 40 with Fully Noded, and recovery should support all of them. Base line are current recommended, which are segwt, nested-segwit, and cosigner 48.,legacy is bitcoin-core hd, electrum legacy (which I think handles change differently), legacy P2PKH (with a variant that I think Bred wallet used)) BIP44 & 45. Then there is the future, which single key taproot is the the most important.

Long-term I hope all of these go away in favor of just exchange of descriptors.

wolfmcnally commented 2 years ago

@Fonta1n3, is there a source of truth you use for the derivations you support, or a document you've produced yourself that I can refer to?

ChristopherA commented 2 years ago

Two different issues here:

In the Key Request pane, it should say what this derivation is for (segwit xpub, co-signer xpub, etc.) if it is a known derivation, and otherwise should give a strong warning if it is for an unknown coin, and a lesser warning if we know the coin, but it we don't know what the child derivation is used for.

I really would like this for our list current small list of standard types for the 1.4 release.

The second issue is that there is larger list of known derivations, that at some release (1.6?) we should support, and do more detail on warning.

wolfmcnally commented 2 years ago

Rescoping for 1.4 to adding the long name (or unknown) to the Key Request screen.

wolfmcnally commented 2 years ago

This should be addressed in the next beta.

shannona commented 2 years ago

@wolfmcnally as of 54, I'm not seeing a description.

IMG_2867

shannona commented 2 years ago

Now showing those details:

IMG_3213