Tweaks for File Names Needed

shannona commented 2 years ago

A few additional notes on finalizing the file name consistency.

All of the QR file names still seem to be in the old format of "[Element] from [where]-[type]", without the seed and/or key prefix. This is the heart of the problem in #141.
There is inconsistency on whether file name prefix is "keyhash" or "seedhash-keyhash". Looking at the cosigner pubkey exports, Lifehash and Name touch-and-hold exports both use just the keyhash, while the UR/crypto-hdkey share uses seedhash-keyhash.
Similarly, of the three, the last is the only one to include extra derivation info in the filename

Here's my examples for the Cosigner Pubkey:

607bf2a-HDKey from Yinmn Blue Acid Exam-PublicHDKey-Lifehash.png
607bf2a-HDKey from Yinmn Blue Acid Exam-PublicHDKey-Name.txt
UR for HDKey from Yinmn Blue Acid Exam-UR.png
ffa11a8-607bf2a-HDKey from Yinmn Blue Acid Exam-PublicHDKey-[604b93f2_48h_0h_0h_2h]-9ff1237f-UR.txt

I'm pretty agnostic on the best practice for the latter two bullet points, through @ChristopherA might have some specific notes. I'm just looking for consistency.

wolfmcnally commented 2 years ago

This feature was not complete, but I promised a "preview release" for Monday and this is what you're seeing. This is why I said: "MOST Share Sheet and Print actions now include..." I do intend for it to be ALL, not MOST, by the next release, but it needs more work.

shannona commented 2 years ago

Here's a file listing from the newest rev:

17e30be-Address from Yinmn Blue Acid Exam-Address-Detail.txt
17e30be-Address from Yinmn Blue Acid Exam-Address-Identifier-Hex.txt
17e30be-Address from Yinmn Blue Acid Exam-Address-Lifehash.png
17e30be-Address from Yinmn Blue Acid Exam-Address-Name.txt
58d4b90-HDKey from Yinmn Blue Acid Exam-PublicHDKey-Detail.txt
58d4b90-HDKey from Yinmn Blue Acid Exam-PublicHDKey-Lifehash.png
58d4b90-HDKey from Yinmn Blue Acid Exam-PublicHDKey-Name.txt
bcab0a2-HDKey from Yinmn Blue Acid Exam-PublicHDKey-Identifier-Hex.txt
bcab0a2-HDKey from Yinmn Blue Acid Exam-PublicHDKey-Lifehash.png
bcab0a2-HDKey from Yinmn Blue Acid Exam-PublicHDKey-Name.txt
f89908c-HDKey from Yinmn Blue Acid Exam-PrivateHDKey-Detail.txt
f89908c-HDKey from Yinmn Blue Acid Exam-PrivateHDKey-Identifier-Hex.txt
f89908c-HDKey from Yinmn Blue Acid Exam-PrivateHDKey-Lifehash.png
f89908c-HDKey from Yinmn Blue Acid Exam-PrivateHDKey-Name.txt
ffa11a8-[group1_1of1]-BELT FLEW LOUD DAYS-SSKR-ByteWords.txt
ffa11a8-[group1_1of1]-BELT FLEW LOUD DAYS-SSKR-UR.png
ffa11a8-[group1_1of1]-BELT FLEW LOUD DAYS-SSKR-UR.txt
ffa11a8-5db8946-Address from Yinmn Blue Acid Exam-Address-[604b93f2].png
ffa11a8-5db8946-Address from Yinmn Blue Acid Exam-Address-[604b93f2].txt
ffa11a8-5db8946-HDKey from Yinmn Blue Acid Exam-Account-0-UR.txt
ffa11a8-5db8946-HDKey from Yinmn Blue Acid Exam-Output-0-UR.png
ffa11a8-5db8946-HDKey from Yinmn Blue Acid Exam-Output-0-UR.txt
ffa11a8-5db8946-HDKey from Yinmn Blue Acid Exam-Output-0.txt
ffa11a8-5db8946-HDKey from Yinmn Blue Acid Exam-PrivateHDKey-[604b93f2]-Base58.txt
ffa11a8-5db8946-HDKey from Yinmn Blue Acid Exam-PrivateHDKey-[604b93f2]-UR.png
ffa11a8-58d4b90-HDKey from Yinmn Blue Acid Exam-PublicHDKey-[604b93f2_48h_1h_0h_2h]-6e640187-UR.txt
ffa11a8-bcab0a2-HDKey from Yinmn Blue Acid Exam-PublicHDKey-[604b93f2]-Base58.txt
ffa11a8-bcab0a2-HDKey from Yinmn Blue Acid Exam-PublicHDKey-[604b93f2]-UR.png
ffa11a8-bcab0a2-HDKey from Yinmn Blue Acid Exam-PublicHDKey-[604b93f2]-UR.txt
ffa11a8-f89908c-HDKey from Yinmn Blue Acid Exam-PrivateHDKey-[604b93f2_48h_1h_0h_2h]-6e640187-UR.png
ffa11a8-f89908c-HDKey from Yinmn Blue Acid Exam-PrivateHDKey-[604b93f2_48h_1h_0h_2h]-6e640187-UR.txt
ffa11a8-Yinmn Blue Acid Exam-Seed-BIP39.txt
ffa11a8-Yinmn Blue Acid Exam-Seed-ByteWords.txt
ffa11a8-Yinmn Blue Acid Exam-Seed-Hex.txt
ffa11a8-Yinmn Blue Acid Exam-Seed-Lifehash.png
ffa11a8-Yinmn Blue Acid Exam-Seed-Name.txt
ffa11a8-Yinmn Blue Acid Exam-Seed-UR.png
ffa11a8-Yinmn Blue Acid Exam-Seed-UR.txt
ffa11a8-Yinmn Blue Acid Exam-SSKR-ByteWords.txt
ffa11a8-Yinmn Blue Acid Exam-SSKR-UR.txt

Here's the main things I'd suggest for consistency:

The Individual shares from the SSKR should be sorted by seedname, maybe by seedname-SSKR, rather than just OIB:

ffa11a8-[group1_1of1]-BELT FLEW LOUD DAYS-SSKR-ByteWords.txt
ffa11a8-[group1_1of1]-BELT FLEW LOUD DAYS-SSKR-UR.png
ffa11a8-[group1_1of1]-BELT FLEW LOUD DAYS-SSKR-UR.txt

Compare to:

ffa11a8-Yinmn Blue Acid Exam-SSKR-ByteWords.txt
ffa11a8-Yinmn Blue Acid Exam-SSKR-UR.txt

(Or at least, these five items should be consistent.)

There's a remaining inconsistency on whether the seed OIB is used as a prefix or not for keys. For example, the following all come from the Cosigner Public Key button:

58d4b90-HDKey from Yinmn Blue Acid Exam-PublicHDKey-Detail.txt
58d4b90-HDKey from Yinmn Blue Acid Exam-PublicHDKey-Lifehash.png
58d4b90-HDKey from Yinmn Blue Acid Exam-PublicHDKey-Name.txt
ffa11a8-58d4b90-HDKey from Yinmn Blue Acid Exam-PublicHDKey-[604b93f2_48h_1h_0h_2h]-6e640187-UR.txt

I think the ones missing the prefix are the touch-and-long-hold share items.

There's also an inconsistency on whether the derivation path appears in the file names, as shown above. Again, I think it's the touch-and-long-hold that are missing the extra info.

As before, I'm somewhat agnostic on what actually appears on the filenames, I just think we want like things to be grouped together.

wolfmcnally commented 2 years ago

If an object was derived from a seed, the Seed ID should always be first. I'll check into this.

wolfmcnally commented 2 years ago

In the next beta:

When long-pressing on the various parts of an Object Identity Block (OIB), and then choosing the Save to Files... option, suggested filenames are now consistent with the identified subject as well as the selected field of the OIB (LifeHash, Identifier, Detail, and Name). All suggested filenames for objects derived from seeds (such as HDKeys and Addresses) now start with the Seed Digest Identifier first and then the Digest Identifier of the derived object.

Examples:

A seed itself: ffa11a8-Dark Purple Aqua Love-Seed-UR.txt

The LifeHash of the seed: ffa11a8-Dark Purple Aqua Love-Seed-Lifehash.png

The Digest Identifier of the seed: ffa11a8-Dark Purple Aqua Love-Seed-Identifier-Hex.txt

The Master HD Key derived from the seed: ffa11a8-5db8946-HDKey from Dark Purple Aqua Love-PrivateHDKey-[604b93f2]-UR.txt

The LifeHash of the Master HD Key: ffa11a8-5db8946-HDKey from Dark Purple Aqua Love-PrivateHDKey-[604b93f2]-Lifehash.png

An HD Public Key derived from the seed: ffa11a8-607bf2a-HDKey from Dark Purple Aqua Love-PublicHDKey-[604b93f2_48h_0h_0h_2h]_9ff1237f-UR.txt

The same HD Public Key in Base58 format: ffa11a8-607bf2a-HDKey from Dark Purple Aqua Love-PublicHDKey-[604b93f2_48h_0h_0h_2h]_9ff1237f-Base58.txt

The LifeHash of the HD Public Key: ffa11a8-607bf2a-HDKey from Dark Purple Aqua Love-PublicHDKey-[604b93f2_48h_0h_0h_2h]_9ff1237f-Lifehash.png

shannona commented 2 years ago

Here's a relatively comprehensive cross-section:

Derivation-Request-PublicHDKey-[48h_0h_0h_2h]-UR.txt
ffa11a8-[group1_1of3]-TRIP HAWK LUNG BELT-SSKR-ByteWords.txt
ffa11a8-[group1_1of3]-TRIP HAWK LUNG BELT-SSKR-UR.png
ffa11a8-[group1_1of3]-TRIP HAWK LUNG BELT-SSKR-UR.txt
ffa11a8-[group1_2of3]-CASH FIZZ MEMO PLAY-SSKR-ByteWords.txt
ffa11a8-[group1_2of3]-CASH FIZZ MEMO PLAY-SSKR-UR.png
ffa11a8-[group1_2of3]-CASH FIZZ MEMO PLAY-SSKR-UR.txt
ffa11a8-[group1_3of3]-ZERO CATS IRIS ROCK-SSKR-ByteWords.txt
ffa11a8-[group1_3of3]-ZERO CATS IRIS ROCK-SSKR-UR.png
ffa11a8-[group1_3of3]-ZERO CATS IRIS ROCK-SSKR-UR.txt
ffa11a8-5db8946-Address from Yinmn Blue Acid Exam-Address-[604b93f2]-Lifehash.png
ffa11a8-5db8946-Address from Yinmn Blue Acid Exam-Address-[604b93f2]-Name.txt
ffa11a8-5db8946-Address from Yinmn Blue Acid Exam-Address-[604b93f2].png
ffa11a8-5db8946-HDKey from Yinmn Blue Acid Exam-Account-0-UR.txt
ffa11a8-5db8946-HDKey from Yinmn Blue Acid Exam-Output-[604b93f2_legacy_0_frs22d0f]-UR.txt
ffa11a8-5db8946-HDKey from Yinmn Blue Acid Exam-Output-[604b93f2_legacymultisig_0_vwnxudyw]-UR.txt
ffa11a8-5db8946-HDKey from Yinmn Blue Acid Exam-Output-[604b93f2_nested_0_cmyxclfa]-UR.png
ffa11a8-5db8946-HDKey from Yinmn Blue Acid Exam-Output-[604b93f2_nested_0_cmyxclfa]-UR.txt
ffa11a8-5db8946-HDKey from Yinmn Blue Acid Exam-Output-[604b93f2_nested_0_cmyxclfa].txt
ffa11a8-5db8946-HDKey from Yinmn Blue Acid Exam-Output-[604b93f2_nestedmultisig_0_ycs6cu6j]-UR.txt
ffa11a8-5db8946-HDKey from Yinmn Blue Acid Exam-Output-[604b93f2_segwit_0_ncwysjuk]-UR.png
ffa11a8-5db8946-HDKey from Yinmn Blue Acid Exam-Output-[604b93f2_segwit_0_ncwysjuk]-UR.txt
ffa11a8-5db8946-HDKey from Yinmn Blue Acid Exam-Output-[604b93f2_segwitmultisig_0_wmsu2266]-UR.png
ffa11a8-5db8946-HDKey from Yinmn Blue Acid Exam-Output-[604b93f2_segwitmultisig_0_wmsu2266]-UR.txt
ffa11a8-5db8946-HDKey from Yinmn Blue Acid Exam-Output-[604b93f2_segwitmultisig_0_wmsu2266].txt
ffa11a8-5db8946-HDKey from Yinmn Blue Acid Exam-Output-[604b93f2_taproot_0_nay7kr6q]-UR.txt
ffa11a8-5db8946-HDKey from Yinmn Blue Acid Exam-PrivateHDKey-[604b93f2]-Base58.txt
ffa11a8-5db8946-HDKey from Yinmn Blue Acid Exam-PrivateHDKey-[604b93f2]-Lifehash.png
ffa11a8-5db8946-HDKey from Yinmn Blue Acid Exam-PrivateHDKey-[604b93f2]-Name.txt
ffa11a8-5db8946-HDKey from Yinmn Blue Acid Exam-PrivateHDKey-[604b93f2]-UR.png
ffa11a8-5db8946-HDKey from Yinmn Blue Acid Exam-PrivateHDKey-[604b93f2]-UR.txt
ffa11a8-5db8946-HDKey from Yinmn Blue Acid Exam-Request-PrivateHDKey-[604b93f2]-UR.txt
ffa11a8-5db8946-HDKey from Yinmn Blue Acid Exam-Response-PrivateHDKey-[604b93f2]-UR.png
ffa11a8-5db8946-HDKey from Yinmn Blue Acid Exam-Response-PrivateHDKey-[604b93f2]-UR.txt
ffa11a8-607bf2a-HDKey from Yinmn Blue Acid Exam-PublicHDKey-[604b93f2_48h_0h_0h_2h]_9ff1237f-Base58.txt
ffa11a8-607bf2a-HDKey from Yinmn Blue Acid Exam-PublicHDKey-[604b93f2_48h_0h_0h_2h]_9ff1237f-Detail.txt
ffa11a8-607bf2a-HDKey from Yinmn Blue Acid Exam-PublicHDKey-[604b93f2_48h_0h_0h_2h]_9ff1237f-Identifier-Hex.txt
ffa11a8-607bf2a-HDKey from Yinmn Blue Acid Exam-PublicHDKey-[604b93f2_48h_0h_0h_2h]_9ff1237f-Lifehash.png
ffa11a8-607bf2a-HDKey from Yinmn Blue Acid Exam-PublicHDKey-[604b93f2_48h_0h_0h_2h]_9ff1237f-Name.txt
ffa11a8-607bf2a-HDKey from Yinmn Blue Acid Exam-PublicHDKey-[604b93f2_48h_0h_0h_2h]_9ff1237f-UR.png
ffa11a8-607bf2a-HDKey from Yinmn Blue Acid Exam-PublicHDKey-[604b93f2_48h_0h_0h_2h]_9ff1237f-UR.txt
ffa11a8-607bf2a-HDKey from Yinmn Blue Acid Exam-Request-PublicHDKey-[604b93f2_48h_0h_0h_2h]_9ff1237f-UR.txt
ffa11a8-607bf2a-HDKey from Yinmn Blue Acid Exam-Response-PublicHDKey-[604b93f2_48h_0h_0h_2h]_9ff1237f-UR.txt
ffa11a8-Yinmn Blue Acid Exam-Request-Seed-UR.png
ffa11a8-Yinmn Blue Acid Exam-Request-Seed-UR.txt
ffa11a8-Yinmn Blue Acid Exam-Response-Seed-UR.png
ffa11a8-Yinmn Blue Acid Exam-Response-Seed-UR.txt
ffa11a8-Yinmn Blue Acid Exam-Seed-BIP39.txt
ffa11a8-Yinmn Blue Acid Exam-Seed-ByteWords.txt
ffa11a8-Yinmn Blue Acid Exam-Seed-Hex.txt
ffa11a8-Yinmn Blue Acid Exam-Seed-Identifier-Hex.txt
ffa11a8-Yinmn Blue Acid Exam-Seed-Lifehash.png
ffa11a8-Yinmn Blue Acid Exam-Seed-Name.txt
ffa11a8-Yinmn Blue Acid Exam-Seed-UR.png
ffa11a8-Yinmn Blue Acid Exam-Seed-UR.txt
ffa11a8-Yinmn Blue Acid Exam-SSKR-ByteWords.txt
ffa11a8-Yinmn Blue Acid Exam-SSKR-UR.txt

All looks good to me.

BlockchainCommons / GordianSeedTool-iOS

Tweaks for File Names Needed #143