BlockchainCommons / GordianSeedTool-iOS

Cryptographic Seed Manager for iOS
Other
36 stars 8 forks source link

Base58 Export Missing from Cosigner Public/Private Key Buttons #148

Closed shannona closed 2 years ago

shannona commented 2 years ago

If you export a Cosigner Public or Private Key using the specialized buttons, you're only allowed to "share as ur:crypto-hdkey" or "print" (the UR) or share the QR (or the UR).

If you "Derive Key"->"Other Key Derivation" for any Derivation, including Cosigner, you're given an extra option of "Share as Base58".

The "Share as Base58" option should be added to the individual Cosigner Public & Private Key buttons for consistency (and generally, I'd suggest just use the same page if possible, because other less important things, such as the developer-test buttons, are also missing.

ChristopherA commented 2 years ago

Though it is not critical, I’d like to see this fixed in 1.4.

wolfmcnally commented 2 years ago

This should be fixed in the next beta release. Please retest.

shannona commented 2 years ago

Verified for pub and prv keys. Thanks.