Suggestion for Change to Key Derivation (i)nfo Text

BlockchainCommons / GordianSeedTool-iOS

Cryptographic Seed Manager for iOS

Other

36 stars 8 forks source link

Suggestion for Change to Key Derivation (i)nfo Text #150

Closed shannona closed 2 years ago

shannona commented 2 years ago

There are a number of examples in "What is Key Derivation" that refer to 48'/0'/0'/0, which turns out to be the largely ignored Legacy Multisig Cosigner. (The older 45' was never superseded, I presume because Segwit came along).

I'd suggest changing these to 48'/0'/0'/2' for better correlation with the actual app.

wolfmcnally commented 2 years ago

May I suggest you make these changes? It is in the markdown file here: https://github.com/BlockchainCommons/GordianSeedTool-iOS/blob/master/SeedTool/Markdown/what-is-key-derivation.md

shannona commented 2 years ago

Is here: https://github.com/BlockchainCommons/GordianSeedTool-iOS/pull/155

wolfmcnally commented 2 years ago

Merged.