BlockchainCommons / GordianSeedTool-iOS

Cryptographic Seed Manager for iOS
Other
36 stars 8 forks source link

UX: Need for Undo or how X/Cancel function in Seed Name Editing #152

Closed ChristopherA closed 2 years ago

ChristopherA commented 2 years ago

Using SeedTool Version 1.4 (54)

Twice now (once on iOS and once on macOS) while editing a seed's Name, I have accidently clicked on the dice button.

The reason why this happens is that the Name field is a single line, and has … at end when the text is too long, so you have to tap the end of the line to get to the end of the text to append to it or edit what you have that is past the … — this often results in accidentally tapping the dice button, which replaces the whole name.

If you try to tap the field to reveal the undo, you can't. On macOS if you command-Z it does not undo. If you click on the X it just deletes the line, and does not undo. You also can't cancel elsewhere in the to restore back to the original.

Some thoughts in addition to puzzling out how to enable undo:

ChristopherA commented 2 years ago

This was particularly problematic in one case. I was editing it and I don't remember what the original name was, and there was no description, so I've had to name it as Unknown. It could be one of my lesser test seeds or from an oddball third-party wallet, but it also might be one with real UTXOs on it. I went to seedtool on my other device, and the name change propagated in iCloud, so I have no idea what this seed is.

I'm elevating this to bug.

wolfmcnally commented 2 years ago

This should be addressed in tonight's beta.

shannona commented 2 years ago

The "..." icon that pops up the dice and clear buttons now disappears when you're editing.

However,

It looks to me like the core problem is likely resolved, but not additional requests @ChristopherA had.

@ChristopherA, is this sufficient to close, possibly adding additional tasks onto long-term lists?

shannona commented 2 years ago

Remaining issues flagged in #172.