BlockchainCommons / GordianSeedTool-iOS

Cryptographic Seed Manager for iOS
Other
36 stars 8 forks source link

Seed Requests and Responses don't conform to spec #156

Closed wolfmcnally closed 2 years ago

wolfmcnally commented 2 years ago

The ur:crypto-requests and ur:crypto-responses for seeds generated by Seed Tool 1.3 do not conform to the examples in the spec.

wolfmcnally commented 2 years ago

This should be addressed in tonight's beta.

shannona commented 2 years ago

A sample request for Yimmn Blue decodes to:

{
  1: 37(h'0842458547c849fda0c172892d76d1b3'), 
  2: 500({1: 600(h'ffa11a8b90954fc89ae625779ca11b8f0227573a2f8b4ed85d96ddf901a72cea')}), 
  3: "Sint fuga nihil id. Perspiciatis animi praesentium perferendis cupiditate ut ut beatae alias culpa qui."
}

That matches the spec.

A response to one of our test vectors returns:

{
  1: 37(h'3cb81644ada44ecb9ddfa285c14fa877'), 
  2: 300({1: h'59f2293a5bce7d4de59e71b4207ac5d2', 
                2: 1(1645539742), 
                3: "Dark Purple Warm Half", 
                4: "This is our standard 128-bit test seed. However, this version of it has a very long note. Why? The object is to force the creation of an animated GIF, which demonstrates the power of URs, not just to allow for the self-identification of information, but also to do so in a way the integrates well with QR codes -- which is where the animated QR comes in. To force that to happen, this note was made to be over 500 characters long, which is around the size that Gordian Seed Tool starts displaying an animated QR rather than a static one. Technically, a QR entirely maxes out at about 4,000 alphanumeric characters, but it gets very hard to read (especially from a phone) before that."
                 })
}

That all looks correct.