Closed ChristopherA closed 5 months ago
We should make a bigger test case for BIP39 seeds. Extra spaces, extra at end or beginning, comma, comma space (or not), CR or CR/LF between. Both full word and 4 characters words. We should make it as easy as possible to bring in old seeds.
Comma separated, space separated, tab separated, and return separated all work in GST 1.6.
I think the major UI issue here is that GST will report "Invalid BIP39 words." as you're typing them in, up to the point where you have a complete, valid set added.
Please retest in next release.
I'm still seeing errors as you type words in, @wolfmcnally , both in the 4-letter form and complete form, only clearing when the last letter of the last word is typed.
Minor suggestion on "No valid SSKR shares found" error message. We should add the word: "yet", ie, "No valid SSKR shares found yet".
A bigger issue: when an error appears, it sticks around. So after I accidentally mistyped "fly" and "fky", I got an "Invalid BIP39 words" message, but it didn't go away when my iPhone helpfully corrected that word.
This still shows "Invalid BIP39 words." as you're typing in correct BIP39 words.
The new red/green/yellow words at bottom are amazing and should be a great UI for entering words. I think we still need to change the error message though.
I suggest "Invalid BIP39 words" only if something comes up red. Otherwise, maybe "BIP39 word import not complete" or "BIP39 words incomplete".
There is a difference between reporting an invalid bip39 word vs the checksum being invalid. User was legitimately confused thinking the world was invalid.
Error shown be more granular: incorrect word, insufficient quantity of words, checksum invalid.