search

BlockchainCommons / GordianSeedTool-iOS

Cryptographic Seed Manager for iOS
Other
36 stars 8 forks source link

Classic ur:crypto-request for Seed or Key fails #192

Closed shannona closed 11 months ago

shannona commented 12 months ago

These are my test vectors: https://github.com/BlockchainCommons/crypto-commons/blob/master/Docs/crypto-request-test-vectors.md

They all failed with unrecognized ur:crypto-request

shannona commented 12 months ago

Animated QR requests for PSBT signing still seem to work fine, so this issue is restricted to requests for keys and seeds

wolfmcnally commented 11 months ago

This is correct. We are replacing all ur:crypto-request and ur:crypto-response with envelope-based requests and responses.

shannona commented 11 months ago

I've marked our crypto-request test vectors as deprecated. We should probably consider writing some new Envelope test vectors, @ChristopherA .

wolfmcnally commented 11 months ago

Yes, and we should deprecate our BCRs with the olde definitions in them and/or update them with the envelope-based definitions.