BlockchainCommons / GordianSeedTool-iOS

Cryptographic Seed Manager for iOS
Other
36 stars 8 forks source link

No Reasonable Way to Respond to a PSBT from Sparrow #198

Closed shannona closed 5 months ago

shannona commented 11 months ago

Sparrow sends a PSBT for signature as an Animated QR of a ur:crypto-psbt. GST should respond with a parallel Animated QR of a ur:crypto-psbt either as the only option or as the primary option. Instead, it tries to send back a ur:crypto-envelope, which Sparrow does not recognize. (It errors out with "Unknown UR Type of Envelope".) This leaves GST generally unable to interact with PSBTs generated by Sparrow.

(Theoretically you could respond by saving a .PSBT file, transferring it, and loading it up into Sparrow, but that's hugely cumbersome.)

Our UR chart lists decent adoption of ur:crypto-psbt, so this is likely backward compatibility that we need to address: https://github.com/BlockchainCommons/Gordian-Developer-Community#urs

shannona commented 11 months ago

(not sure which to label for functionality that's gone away in a recent version; choose bug or enhancement as you prefer.)

shannona commented 8 months ago

Is this issue still open, @wolfmcnally ? How much effort will it take to fix if Christopher gives it priority?

shannona commented 6 months ago

GST does now properly return a ur:crypto-psbt if that's what it gets as input, but only the share functionalities are available, which means that there's no way to reasonably return it as a QR after you've read in a QR.

To finalize this, I think we need:

1) a QR if GST is returning an older form of request, such as a ur:crypto-psbt. 2) IMO, that default response should always be placed first as well, so as not to confuse users.

E.g:

A. crypto-psbt B. Envelope C. PSBT file.

After reading in a crypto-psbt

shannona commented 6 months ago

Reflagging this for @wolfmcnally

shannona commented 5 months ago

Looks good.