BlockchainCommons / GordianServer-macOS

Tor-protected full-node GordianServer for macOS
Other
63 stars 8 forks source link

Fixes. #147

Closed Fonta1n3 closed 3 years ago

Fonta1n3 commented 3 years ago

This PR fixes issues:

shannona commented 3 years ago

I've taken another spin through, and am satisfied.

148 seems resolved from the best testing I could do, and Christopher confirms #150 is fixed.

I stepped through lots of creation and recreation of servers, I tested out all the menu functionality, I use the QuickConnect QR to connect to Gordian Wallet and then created a wallet and verified it was visible through the Server.

I did file two bugs regarding stopping and starting Bitcoin, which are #151 (which is slightly notable) and #152 (which is minor had hard to replicate).

However, overall this looks like a strong improvement over our previously released version. I'd suggest approving it and merging it so that we can release as 1.0.0.