search

BlockchainCommons / GordianServer-macOS

Tor-protected full-node GordianServer for macOS
Other
63 stars 8 forks source link

Kill tor when machine goes to sleep #168

Closed Fonta1n3 closed 3 years ago

Fonta1n3 commented 3 years ago

This PR:

shannona commented 3 years ago

Tested out on my M1 Pro MacBook (2021) running Monterey (12.0). Seems fine. Started and stopped mainnet and testnet and tor. Refreshed hidden services. Verified signatures. Linked via QuickConnect to Gordian Wallet and Fully Noded.

Put it to sleep and awakened it. Closed laptop, waited for it to lose connection, and opened. Both seemed to recover correctly.

Some bugs remains, particularly #162 (occasionally, but I hit it on my first test of the DMG) and #163 (whenever there are two networks), but since those are extant I wouldn't suggest getting in the way of the new release.

Test out most of the menu items. Bitcore Core Config doesn't seem to do anything, otherwise fine.

Glanced through the code, and this changes are minimal, so I would suggest a quick, easy release of this.

As noted above, I also merged back some informational updates: marking this as 1.0.1 and updating the copyright to say Blockchain Commons and 2021.

shannona commented 3 years ago

The Config file problem seem consistent, but only on my M1 Pro testbed, not my old Intel testbed. Filed as #170.

shannona commented 3 years ago

Did the same tests on my intel Mac Mini (2018) running Monterey (12.0.1). Everything worked including, as alluded to the bug I'd hit with the config file only on my M1 (#170).

Would suggest releasing.

shannona commented 3 years ago

Per @ChristopherA, merging