RPC Authentication - Githubissues

BlockchainCommons / GordianServer-macOS

Tor-protected full-node GordianServer for macOS

Other

63 stars 8 forks source link

RPC Authentication #182

Closed Fonta1n3 closed 8 months ago

Fonta1n3 commented 1 year ago

This PR:

Makes GS compatible with arm64 and x86_64 binaries for Bitcoin Core.
GS now code signs Bitcoin Core binaries if arm64 is utilized, otherwise bitcoind scripts fail.
Fixes a bug where the VERSION environment variable was being set incorrectly. Which may have caused a bug.
Parses the currentVersion variable correctly for Bitcoin Core v25.0.0.
Bitcoin Core v25.0.0 is now the default.

Fonta1n3 commented 10 months ago

https://github.com/BlockchainCommons/GordianServer-macOS/pull/182/commits/9d152f7f5dd9357dc348cf0bf85e6c9f4d8e5c59 fixes an annoying bug that currently pops up if running v25.0, it will constantly ask you to downgrade to Bitcoin Core v24.2.

shannona commented 10 months ago

Thanks! I'm putting it on our TODO to test and release, but We're closing out the year right now, so it'll likely be January.

Fonta1n3 commented 8 months ago

Hey @shannona and @ChristopherA , I just removed python completely and am generating the rpc creds with native swift code, I think this PR is now mergable?

shannona commented 8 months ago

Thanks @Fonta1n3! We've got limited resources, but we've now got this on our TODO, and I'm hoping to be able to test & rerelease with your patches next week.

shannona commented 8 months ago

merging this into dev for testing.