BlockchainCommons / GordianServer-macOS

Tor-protected full-node GordianServer for macOS
Other
63 stars 8 forks source link

Need Quit Button and/or enable Quit menu when incompatible bitcoin.conf #70

Open ChristopherA opened 3 years ago

ChristopherA commented 3 years ago

Gordian Screen Shot 2020-10-31 at 2 15 44 PM

Installed Gordian Server v0.1.4 tagged .dmg over an old Standup.app on my mainnet Mac mini. Got this error. Note that my configuration I had my bitcoin directory in a non-standard place as set by Standup.app (it should be at ~/Library/Application\ Support/Bitcoin but mine is at /Volumes/Media/Bitcoin/

You can't quit Gordian Server v0.1.4 from menu bar if you see get this error. The OK button isn't OK, it should be Quit so you can go back to edit bitcoin.conf.

Other notes:

There are other problems after this that may be significant, but may be addressed by just fixing the above:

ChristopherA commented 3 years ago

If you do decide to have an option to delete the network line from bitcoin.conf you should backup the old bitcoin.conf to bitcoin.conf.<timestamp>.

ChristopherA commented 3 years ago

For reference, my "Ready to Standup" window after I deleted "testnet=1" entry: Gordian Server Screen Shot 2020-10-31 at 2 38 57 PM

and my bitcoin.conf

disablewallet=0
rpcuser=XXXX
rpcpassword=XXXX
server=1
prune=1
txindex=0
proxy=127.0.0.1:9050
listen=1
debug=tor
[main]
rpcbind=127.0.0.1
rpcallowip=127.0.0.1
bind=127.0.0.1
rpcport=8332
[test]
rpcbind=127.0.0.1
rpcallowip=127.0.0.1
bind=127.0.0.1
rpcport=18332
[regtest]
rpcbind=127.0.0.1
rpcallowip=127.0.0.1
bind=127.0.0.1
rpcport=18443
Fonta1n3 commented 3 years ago

Just a few comments:

Not sure what version you were on but 0.1.4 has breaking changes with older versions as was mentioned in the PR. You should most definitely delete the old standup directory before updating. Namely the location of the standup directory has changed among other things.

You can specify a custom datadir with GS via settings where it will look for a bitcoin.conf, tap the gear button on the home screen and edit the path for Data Directory. GS will only ever look for the bitcoin.conf in this location which is by default the default location.

There is a button for opening the bitcoin.conf: gear button > configs > bitcoin

ChristopherA commented 3 years ago

I’m trying to make key decisions easier. You keep forgetting that new users don’t know to delete the old standup, users don’t know to get to preferences where to find details. If you present a error to them, you also need to give them the specific actions they can do to correct that error. Don’t require them to have your understanding of bitcoin and the app.