BlockchainCommons / GordianWallet-iOS

iOS wallet linked by Torgap to your own full-node server
Other
47 stars 14 forks source link

Cannot add a signer #100

Closed mflaxman closed 3 years ago

mflaxman commented 3 years ago

I'm following the instructions in https://github.com/BlockchainCommons/GordianWallet-iOS/issues/96

And to use Gordian as a signer for this quorum, you:

    Accounts > tap your account to "activate it"
    Tap the tools button in top right
    Tap add a signer

When I add a signer, I'm trying to input the phrase defense defense defense defense defense defense defense defense defense defense defense defense defense defense defense defense defense defense defense defense defense defense defense another but there's no submit button or way forward:

IMG_1091

I also can't see past word #18 in case I had any typos, but that's a separate UI issue.

Fonta1n3 commented 3 years ago

Hmm it automatically checks if the mnemonic is valid and prompts you. Will make that view scrollable.

ChristopherA commented 3 years ago

Be careful, there are 24 word BIP39 mnemonics where the first 12 words are also a valid mnemonic.

Fonta1n3 commented 3 years ago

@mflaxman @ChristopherA Looks like Libwally does not recognize defense defense defense defense defense defense defense defense defense defense defense defense defense defense defense defense defense defense defense defense defense defense defense another as a valid bip39 mnemonic, will need to raise an issue there.

Fonta1n3 commented 3 years ago

97 fixes the issue of the view not being scrollable, unfortunately fixing Libwally to recognize that as a valid mnemonic is going to take more time, perhaps they have some sort of minimum entropy required? Every single mnemonic I have ever tested works except that one...

Fonta1n3 commented 3 years ago

@mflaxman @ChristopherA Looks like Libwally does not recognize defense defense defense defense defense defense defense defense defense defense defense defense defense defense defense defense defense defense defense defense defense defense defense another as a valid bip39 mnemonic, will need to raise an issue there.

This is incorrect, it was a bug on my part where I was only checking for 12 words mnemonics when "refilling the keypool" or "adding a signer", actually recovering an account with a 24 word mnemonic was not effected which is why it slipped through the cracks. Good find.