ChristopherA
commented
3 years ago This PR had whatever build settings that requires registering the simulator with iCloud. Most other previous PRs did not require this with some debug mode. If you in the future can make sure that is off for PRs to master it would be appreciated.
This PR adds some important updates:
we now automatically add range to any non ranged descriptor, for example Sparrow Wallet and LetheKit do not provide a ranged descriptor when exporting wallets
we now lexicographically sort the xpubs when we import an Account Map, that way we can always know for certain similar accounts will result in the same wallet.dat filename which results in greatly improved UX as we will always automatically reuse the correct wallet.dat file on the node, and it guarantees the lifehash will be identical even if the user creates their descriptor with xpub's in a different order then another wallet software may have. See this issue for more explanation: https://github.com/cryptoadvance/specter-desktop/issues/436
we no longer wait for a response from bitcoind when intitiating a rescan as it bogs everything down and can take a very long time. Results in much improved UX around wallet recovery and importing.