search

BlockchainCommons / GordianWallet-iOS

iOS wallet linked by Torgap to your own full-node server
Other
47 stars 14 forks source link

Fixes #110 #111

Closed Fonta1n3 closed 2 years ago

Fonta1n3 commented 3 years ago

fix: update beta label for testing node for App Store purposes

fix: fixes #110, if no recipient is specified do not assume addresses are change, this happens when a psbt is uploaded externally instead of created via the out tab

ChristopherA commented 3 years ago

I tried building this, and I get:

Swift Compiler Error Group
/Users/christophera/Library/Developer/Xcode/DerivedData/GordianWallet-cxxdijbptomjasdjvrujaghbtfvy/Build/Products/Debug-iphoneos/SSKR.framework/Modules/SSKR.swiftmodule/arm64-apple-ios.swiftinterface:4:8: No such module 'CSSKR'
/Users/christophera/projects/github/BlockchainCommons/GordianWallet-iOS/XCode/GordianWallet/View Controllers/Wallets/Wallet Recovery/WalletRecoverViewController.swift:11:8: Failed to build module 'SSKR' from its module interface; the compiler that produced it, 'Apple Swift version 5.2.2 (swiftlang-1103.0.32.6 clang-1103.0.32.51)', may have used features that aren't supported by this compiler, 'Apple Swift version 5.3 (swiftlang-1200.0.29.2 clang-1200.0.30.1)'

and

Warning Group
Wallets.xprvs is using a nil or insecure value transformer. Please switch to NSSecureUnarchiveFromDataTransformerName or a custom NSValueTransformer subclass of NSSecureUnarchiveFromDataTransformer [2]
Fonta1n3 commented 3 years ago

As per #121 I have moved this PR into draft status.

I will quickly fix #121 but the codebase will need much more testing as so much was changed (and not tested) in https://github.com/BlockchainCommons/GordianWallet-iOS/pull/111/commits/fd31756c98902e3021191f9b5b87a19e7222b57a.

shannona commented 2 years ago

Merging to bring us up to date with Testflight Gordian releases.