search

BlockchainCommons / GordianWallet-iOS

iOS wallet linked by Torgap to your own full-node server
Other
47 stars 14 forks source link

Cannot build. #16

Closed brett-doffing closed 4 years ago

brett-doffing commented 4 years ago

'origins' is inaccessible due to 'internal' protection level

ScannerViewController, line 174 let origins = input.origins

Fonta1n3 commented 4 years ago

I assumed changes I make to the LibWally pod would be reflected in my commits... I guess not. Yea we need to access the path property directly to do offline signing of PSBT's. To fix you can open "project navigator" -> "Pods" -> "Pods" -> "LibWally" -> "PSBT.swift" -> and change let path: BIP32Path on line 14 to public let path: BIP32Path. Will submit a PR to LibWally-Swift to see if they can expose it so we only need to do minimal alterations. FYI there is a bug with PSBT signing in the library where it only works for multi-sig transactions.

brett-doffing commented 4 years ago

Should I close an issue such as this if it is not fully resolved by the dependency?

Fonta1n3 commented 4 years ago

AFAIAC if the info I gave you allows you to build the app then the issue can be closed. Probably worth adding to the readme that the library needs to be slightly modified for the app to build from source though and worth submitting a PR to LibWally-Swift to see if they are ok making those changes so we do not have to. They have already made a few on our behalf.

brett-doffing commented 4 years ago

Actually had to make let origins: [PubKey: KeyOrigin]? public on line 36 as well. At this point we're just hacking away at a dependency just to get things to work, which I do not recommend.

Fonta1n3 commented 4 years ago

I would suggest submitting a PR to LibWally-Swift.