search

BlockchainCommons / GordianWallet-iOS

iOS wallet linked by Torgap to your own full-node server
Other
47 stars 14 forks source link

'privKey' is inaccessible due to 'internal' protection level #3

Closed brett-doffing closed 4 years ago

brett-doffing commented 4 years ago

It seems there are two cases where privKey of HDKey (LibWally) is trying to be accessed. In KeyFetcher.swift, line 51, and ExportKeysViewController.swift, line 403. Project will not build. I modified the code to get it to build, but do not know the consequences of this as that is all I was trying to do.

Fonta1n3 commented 4 years ago

Yep that needs to be modified, we need to be able to fetch private keys to sign the transactions throughout the app so making that variable public is the fix. You can see this issue for background.

Fonta1n3 commented 4 years ago

This is modified and I do not see any negative consequences, we just need to be careful with how we use the private keys. Closing for now.