search

BlockchainCommons / GordianWallet-iOS

iOS wallet linked by Torgap to your own full-node server
Other
47 stars 14 forks source link

Add logo to Readme.md #92

Closed bcksenanayake closed 3 years ago

bcksenanayake commented 3 years ago

Regarding #91

Added the logo to the readme file.

ChristopherA commented 3 years ago

I’d prefer to not have a remote link to logo. Can you upload the image with this PR and make it a local link?

Fonta1n3 commented 3 years ago

That is also not the Gordian Wallet logo? Would you like me to add it or you want the BlockchainCommons logo?

Fonta1n3 commented 3 years ago

Went ahead and updated this PR to my current master branch which now includes the logo file in ./Images/GordianWallet_logo.png

@ChristopherA I have not submitted a PR with my recent changes which are now here bc we are still waiting on Gauthams PR to be merged.

Fonta1n3 commented 3 years ago

@bcksenanayake fwiw if you just need to use the logo here is the location in my fork: https://github.com/Fonta1n3/GordianWallet-iOS/blob/master/Images/GordianWallet_logo.png

bcksenanayake commented 3 years ago

I’d prefer to not have a remote link to logo. Can you upload the image with this PR and make it a local link?

On it.

ChristopherA commented 3 years ago

Currently it is pointing to your branch repo. The actual file should be submitted to this repo as part of this PR, and the link should be to this repo.

I know kind of complicated, but we have to be more careful with secure software repos. We don't someone hijacking an image elsewhere and because we inadvertently point to it allow for a social attack against our software.

Fonta1n3 commented 3 years ago

Currently it is pointing to your branch repo. The actual file should be submitted to this repo as part of this PR, and the link should be to this repo.

I know kind of complicated, but we have to be more careful with secure software repos. We don't someone hijacking an image elsewhere and because we inadvertently point to it allow for a social attack against our software.

This PR includes the commits.

ChristopherA commented 3 years ago

The link in the submitted README is <img src="https://github.com/bcksenanayake/GordianWallet-iOS/blob/master/Images/GordianWallet_logo.png" alt="Logo" width="300"/><br/>

Fonta1n3 commented 3 years ago

I’ve added the logo to

./Images/GordianWallet_logo.png

bcksenanayake commented 3 years ago

Is this correct?

bcksenanayake commented 3 years ago

@ChristopherA Hey, can you kindly add "hacktoberfest-accepted" label to my PR? So my contribution would count towards Hacktoberfest.

image

Please be kind enough to consider my message.