search

BlockchainCommons / GordianWallet-iOS

iOS wallet linked by Torgap to your own full-node server
Other
47 stars 14 forks source link

UR crypto-psbt support #97

Closed Fonta1n3 closed 3 years ago

Fonta1n3 commented 3 years ago

Fixes #96 #95 #92 #91

Fonta1n3 commented 3 years ago

Tested NACK: Built on macOS Catalina (10.15.6) (inside VMware 11.5.6) using Xcode 11.7.

Built with no errors on freshly installed VM snapshot post-Xcode install, for target iPhone SE Simulator, using the following:


brew install carthage

git clone git@github.com:BlockchainCommons/GordianWallet-iOS.git

cd GordianWallet-iOS

gh pr checkout 97

open XCode/GordianWallet.xcodeproj

A number of problems:

When wallet starts up, it shows me "Scan QR Code", however, does not ask me the normal startup scripts. As the simulator in this VM has never been run before, this does not make sense, as it should go through "open wallet the first time" script first.

Second, I am unable to select our testing node. I presume this maybe because this build is mainnet? We should not have mainnet builds to master yet. If this build is not mainnet there is some other problem. In any case, I can't test.

Lastly, on this "Scan a QR Code" screen I can't click on the X to close the scan to see what is going on, or try killing the settings, and such.

So totally stuck on testing this PR.

Not mainnet.

Not sure what scripts your talking about.

Will test on a fresh install to see if I can figure out what you mean.

ChristopherA commented 3 years ago

Scripts=All the initial startup text screens you have to go through. Somehow in this version they are gone and first thing you see is Scan window which can’t be closed with x box

Fonta1n3 commented 3 years ago

Scripts=All the initial startup text screens you have to go through. Somehow in this version they are gone and first thing you see is Scan window which can’t be closed with x box

ah OK, will send an update address all these issues shortly.

Fonta1n3 commented 3 years ago

@ChristopherA Your onboarding issues and scanning issues should be resolved now as well as #98 #101 #99 and a few other things I noticed which are itemized in the commit messages.

Please do try again.