Correctly decode multi-share SLIP-39 URs.

BlockchainCommons / seedtool-cli

Cryptographic Seed Tool for the command line

Other

25 stars 16 forks source link

Correctly decode multi-share SLIP-39 URs. #26

Closed wolfmcnally closed 3 years ago

wolfmcnally commented 3 years ago

Fixed bug where multi-share URs like SLIP-39 were not decoded correctly due to support for multi-part URs being added. Seedtool now supports either decoding a multi-part UR or a multi-share UR where the shares are encoded as URs, but not both simultaneously.
Added example to MANUAL of decoding URs containing SLIP-39 shares.

ChristopherA commented 3 years ago

I suspect that we really should block SLIP39 to seed. At best we can only go directly SLIP39 to master XPRV, but seedtool doesn't offer that.

ChristopherA commented 3 years ago

@ksedgwic Am I correct, that slip39 to seed is worthless? At best, if we wanted to (and I doubt't) we'd have to add to keytool the ability to go from slip39 shards directly to master xprv the way trezor does it — any return to seed risks someone trying to use that seed with BIP39 and end up with a wrong xprv.