search

BlockchainCommons / seedtool-cli

Cryptographic Seed Tool for the command line
Other
27 stars 16 forks source link

Add Dockerfile to make the build process more easy, secure, and hermetic #44

Closed secinthenet closed 3 years ago

secinthenet commented 3 years ago

This issue is relevant to all BlockchainCommons tools. The current build process requires installing llvm 10 (and possibly other dependencies in the future), which requires build privileges and is not always desirable. In addition, building is not hermetic, it can be affected be anything already installed on the build machine. A better approach, both in terms of build reproduciblity and user friendliness, is providing a Dockerfile and/or using a build system such as Bazel.

secinthenet commented 3 years ago

I sent a PR that adds a Dockerfile. If it's merged, this issue can be closed, but I'll open another issue to make the build reproducible (Docker doesn't guarantee that).

wolfmcnally commented 3 years ago

I sent a PR that adds a Dockerfile. If it's merged, this issue can be closed, but I'll open another issue to make the build reproducible (Docker doesn't guarantee that).

The only problem with your PR was that it wasn't GPG signed. See comments there.