search

BlockchainLabsNZ / LAToken-Contracts-Audit

0 stars 6 forks source link

Unable to harvest/exchange unless minter is set to the LATokenMinter contract #34

Closed IsaacPayne closed 7 years ago

IsaacPayne commented 7 years ago

The minter contract address needs to be set as the minter to harvest or exchange but needs to be set to a standard ethereum address to burn

matt-lough commented 7 years ago

When you call the harvest function it calls issueTokens in the token contract here

issueTokens has an onlyMinter modifier on it, since this function is being called from harvest the msg.sender when it reaches issueTokens is the contract address of the minter. here

To get around this you can set the minter contract address as the minter for your token, but this means that the exchanger can not exchange until you change the minter to the exchange contracts address.

If this isn't clear then please feel free to shoot us a message.

salis commented 7 years ago

@ElKornacio minter can't be responsible for burning. Would founder be the right address for calling burn?

matt-lough commented 7 years ago

Fixed https://github.com/BlockchainLabsNZ/LAToken-Contracts-Audit/commit/7ae186fe3ccd92898fbe3d3eb8007e6e6c65d95a