search

BlockchainLabsNZ / mothership-sen

GNU General Public License v3.0
0 stars 0 forks source link

Favour require() over If() statements #1

Open 0x00000002 opened 6 years ago

0x00000002 commented 6 years ago

Line 134 of MiniMeToken.sol

if (allowed[_from][msg.sender] < _amount)
    return false;

it is better to keep the "require()" from the original MiniMeToken.sol, Line 154:

require(allowed[_from][msg.sender] >= _amount);
satyrius commented 6 years ago

Fixed https://github.com/mothershipcx/sen-contracts/pull/3/commits/1255820c25742c9be924baf473ffb5bf1e0e9871