Blockchair / Blockchair.Support

Public repository for issues and feature requests. Submit your favorite bug!
455 stars 323 forks source link

Handle duplicate coinbase TXIDs #262

Open DesWurstes opened 4 years ago

DesWurstes commented 4 years ago

Hi, I'm afraid the best way to handle these exceptions is to hardcode them to searching code (or to wontfix it).

In Bitcoin and BCH and BSV these transactions appear in two blocks:

e3bf3d07d4b0375638d5f1db5255fe07ba2c4cb067cd81b84ee974b6585fb468 91722 91880 d5d27987d2a3dfc724e359870c6644b40e497bdc0589a033220fe15429d88599 91812 91842

When searching for the hash, search only shows the transaction in earlier blocks.

Actual behavior:

Expected behavior:

Har01d commented 4 years ago

Hi,

Well, actually these transactions are in our databases:

https://blockchair.com/bitcoin/transactions?q=hash(e3bf3d07d4b0375638d5f1db5255fe07ba2c4cb067cd81b84ee974b6585fb468)#

https://blockchair.com/bitcoin/transactions?q=hash(d5d27987d2a3dfc724e359870c6644b40e497bdc0589a033220fe15429d88599)#

That’s why we don’t use transaction hash as a unique key in our architecture. But we do use it in order to access pages. I.e. like this: https://blockchair.com/bitcoin/transaction/d5d27987d2a3dfc724e359870c6644b40e497bdc0589a033220fe15429d88599

But it’s also possible to access these transactions via internal id: https://blockchair.com/bitcoin/transaction/142726 https://blockchair.com/bitcoin/transaction/142783

Since that’s a rare edge case I don’t think we can get that a priority and fix the search functionality… But maybe some time in the future… :)