search

Blockrazor / blockrazor

Absolutely ALL information about EVERY blockchain project in a comparison tool that ANYONE can understand. Administered by @gazhayes
Mozilla Public License 2.0
47 stars 54 forks source link

Problem : Email password is in code #1921 #1923

Closed MadanBhandari closed 6 years ago

MadanBhandari commented 6 years ago

Solution :

  1. Email settings moved to settings.json
  2. Readme updated for meteor settings
  3. settings.json added to .gitignore
MadanBhandari commented 6 years ago

We need to pass settings.json by meteor --settings settings.json on production, I believe this the reason for failed build.

ping @gazhayes @anbud

dilpreetsio commented 6 years ago

Lets move the config to .env instead of using a json for storing credentials. @gazhayes @MadanBhandari @anbud What do you think?

gsovereignty commented 6 years ago

Yeah we're running node in production so better to use node env settings not meteor

MadanBhandari commented 6 years ago

Okay, I am looking into this.

gsovereignty commented 6 years ago

Can you validate on production, let me know if you need server side logs.