search

Blockrazor / blockrazor

Absolutely ALL information about EVERY blockchain project in a comparison tool that ANYONE can understand. Administered by @gazhayes
Mozilla Public License 2.0
47 stars 54 forks source link

problem: can't sort suspicious IP's by IP login time #1983

Closed gsovereignty closed 5 years ago

gsovereignty commented 5 years ago

Problem: the last login time on the duplicate account IP list is based on the user login time. This means that any IP that has ever been used by a user is pushed to the top of the list whenever that user logs in. This makes it hard to distinguish by IP address.

Solution: add a new data point: last time this IP was used. Keep the existing sort method but add this data point to the list in an extra column. It should also be added to the UX as a sort option but this whoever takes this issue (@anbud I'm guessing) can add the UX sort thing as a new issue when they have solved this one (and all the objects are there already and easily used by UX people).

anbud commented 5 years ago

Yap, it's me, @emurgobot claim. I'll add the sort functionality and UI/UX guys can make it pretty. :)

anbud commented 5 years ago

Done in #2001.

@emurgobot done

gsovereignty commented 5 years ago

OK this isn't quite fixed.

Sorting by the last IP access time still just sorts by the last time any user who has ever used that IP last accessed the site FROM any IP. However for it to be useful it has to be sorted by the last time the site was accessed from that IP.

Let me know if this makes sense or not

anbud commented 5 years ago

It should be doing exactly the thing you've described, I'll check out what's happening. It could be that missing data is causing this behavior as last access time for IPs wasn't saved until this PR.

anbud commented 5 years ago

@emurgobot claim

anbud commented 5 years ago

Fixed in #2017. Sorting should work properly even if there's data missing.

anbud commented 5 years ago

@emurgobot done