search

Blockstream / Jade

Jade hardware wallet
MIT License
319 stars 49 forks source link

Feature request: add display option to flip vertically the screen #134

Closed Drew72-ita closed 3 weeks ago

Drew72-ita commented 4 months ago

Request to add settings -> display option to flip vertically the screen:

JamieDriver commented 4 months ago

I assume you mean 'rotate 180 degrees' ? If so, we partially did this from the outset, but at the time veered away from it due to concerns about the display not being quite right (and ofc having 100 other more pressing things to implement!) Eagle-eyes can still spot code related to screen orientation and inverting wheel/buttons in the codebase, so as you suggest it should be possible to reanimate that. I'll take a look and we'll discuss priorities internally.

Drew72-ita commented 4 months ago

Yes, sorry 180 deg. rotation is more correct. ty ^_^

JamieDriver commented 4 months ago

This should make it into the next release, or worse case the one after :+1:

Drew72-ita commented 4 months ago

Wow thank you very much ^_^

JamieDriver commented 1 month ago

Included in the (newly released) 1.0.31 fw for diy hardware only.

If so, we partially did this from the outset, but at the time veered away from it due to concerns about the display not being quite right (and ofc having 100 other more pressing things to implement!)

Yes, there is an issue with the screen used for older Jade hw which has causes artifacts if we flip the screen orientation. So atm only enabled for 'diy' hardware.

Future batches of proper Jade hw have a better screen without this issue - this will be detected and 'flip screen' will be enabled in this case...

Apologies it's not 100%...

Drew72-ita commented 1 month ago

Thank you, I will test it on my next firmware update : )

Drew72-ita commented 1 week ago

Tested and seems fine.

Just out of curiosity: was this new feature the reason the JADE splash logo was removed at startup? (maybe it interfers with images loading at startup?)

JamieDriver commented 1 week ago

No, unrelated :-) Maybe partly because image data is now kept zipped in the binary, and has to be unzipped in RAM, which some 'diy' devices don't have much of ... and maybe partly to differentiate official jade devices from 'diy' ... not totally sure tbh.