search

Blockstream / Jade

Jade hardware wallet
MIT License
329 stars 55 forks source link

Register CSV accounts on the Jade #36

Closed georgantas closed 2 months ago

georgantas commented 2 years ago

It would be nice to be able to register CSV accounts on the Jade similar to the multisig implementation. If an account is registered with an xPub that isn't Blockstream's, a warning could be displayed during registration.

I think it would also be more secure because an attacker could pass a non-standard csv_blocks parameter, and ask for ransom (not sure if this would trigger a warning currently).

JamieDriver commented 2 years ago

fyi jade should display a warning if the csv value is not in the expected list.

georgantas commented 2 months ago

I think this should be possible with miniscript descriptors now. I will resolve the issue.