search

Blockstream / electrs

An efficient re-implementation of Electrum Server in Rust
MIT License
320 stars 131 forks source link

getblocks retry 5 times on "Block not found on disk" before giving up #118

Closed RCasatta closed 1 month ago

RCasatta commented 1 month ago

alternative to #117

shesek commented 1 month ago

The implementation looks good, but perhaps make this part of Daemon::getblocks()?

Daemon is already responsible for retrying on connection errors, so it can fit there. Also we might later want to add limits and sleeping to the connection retry implementation, which could share some constants with this (the two cases are not exactly the same but we could probably still use the same MAX_ATTEMPTS RETRY_WAIT_DURATION for both).

RCasatta commented 1 month ago

The implementation looks good, but perhaps make this part of Daemon::getblocks()?

Done in #121