search

Blockstream / electrs

An efficient re-implementation of Electrum Server in Rust
MIT License
301 stars 125 forks source link

Fix output indexes to be represented as a u32 (*requires reindex*) #69

Open shesek opened 7 months ago

shesek commented 7 months ago

Bitcoin's consensus rules allows for output indexes larger than u16, which would result in an overflow prior to this fix.

This recently happened with a transaction on testnet: https://blockstream.info/testnet/tx/ca3b75556430e1adf9e9790bce9c73a3d9afdb42305588e64c65b258c06c05c9

Based on @junderw's https://github.com/mempool/electrs/pull/75. Thanks!

This PR branch is based on top of #67, which should get merged first.

Note that this change requires a full database reindex.

LeoComandini commented 7 months ago

utACK 8a695383c7628acfd2b4ba84ca15b7acb4aed759, code review

shesek commented 7 months ago

Rebased.

sammy007 commented 3 months ago

Any ETA on merging this obviously necessary fix?